This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[fix][transaction] Use pulsar format when write marker to __consumer_offsets topic #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
=========================================
Coverage 17.05% 17.06%
Complexity 728 728
=========================================
Files 191 191
Lines 14235 14239 +4
Branches 1332 1334 +2
=========================================
+ Hits 2428 2430 +2
- Misses 11631 11633 +2
Partials 176 176
|
gaoran10
reviewed
Aug 9, 2023
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/utils/MetadataUtils.java
Outdated
Show resolved
Hide resolved
gaoran10
approved these changes
Aug 10, 2023
BewareMyPower
approved these changes
Aug 15, 2023
Demogorgon314
added a commit
to Demogorgon314/kop
that referenced
this pull request
Oct 30, 2023
…offsets topic (streamnative#1994) ### Motivation We should use pulsar format to encode the marker when writing into the `__consumer_offsets` topic, otherwise it will have the following errors: ``` 2023-08-09T09:17:18,398+0000 [pulsar-client-io-69-3] ERROR org.apache.pulsar.client.impl.ConsumerImpl - [public/__kafka/__consumer_offsets-partition-42][reader-ca0ccccd79] Discarding corrupted message at 6:5 2023-08-09T09:17:18,402+0000 [pulsar-client-io-69-3] WARN org.apache.pulsar.client.impl.ConsumerImpl - [reader-ca0ccccd79] [98942] unable to obtain message in batch java.lang.IllegalStateException: java.lang.IllegalStateException: Some required fields are missing ``` ### Modifications Use pulsar format when write marker to __consumer_offsets topic (cherry picked from commit 5193592)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should use pulsar format to encode the marker when writing into the
__consumer_offsetstopic, otherwise it will have the following errors:Modifications
Use pulsar format when write marker to __consumer_offsets topic
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)